Re: [dev] snotes v0.9 - a simple notes system

From: markus schnalke <meillo_AT_marmaro.de>
Date: Tue, 05 Feb 2013 15:41:00 +0100

[2013-02-05 15:22] v4hn <me_AT_v4hn.de>
> On Tue, Feb 05, 2013 at 02:18:18PM +0100, markus schnalke wrote:
>> [2013-02-05 13:16] v4hn <me_AT_v4hn.de>
>>> SNOTES_EDITOR=${VISUAL:-${EDITOR:-vi}}
>>> SNOTES_EDITOR="xterm -e $SNOTES_EDITOR"
>>> cat > $HOME/.snotes/config <<EOF
>>> SNOTES_EDITOR="$SNOTES_EDITOR"
>>> [...]
>>>
>>> You may choose.
>>
>> The first two of my suggestions are very much ideoms, whereas
>> both of your suggestions would produce unexpected behavior for me.
>
> I honestly don't see any unexpected behaviour here.

I'd expect that changing VISUAL would change the default editor
in applications at startup time not at installation time.


>> Let my suggest a solution: [...]
>>
>> SNOTES_EDITOR="xterm -e ${VISUAL:-${EDITOR:-vi}}"
>
> Fine with me, I just pushed this. Thank you for your criticism.

Great! Thanks for the discussion. :-)


meillo
Received on Tue Feb 05 2013 - 15:41:00 CET