Re: [dev][st] st.c:2548: warning: unused variable 'minor' and 'major'

From: Christoph Lohmann <20h_AT_r-36.net>
Date: Thu, 21 Feb 2013 06:41:01 +0100

Greetings.

On Thu, 21 Feb 2013 06:41:01 +0100 Nikolay Vasylchyshyn <vasylchyshynni_AT_gmail.com> wrote:
> Hello guys!
> Pulled today fresh st git repo.
> My compiler complains about unused variables.
> So, I commented it out. Here is a patch.
>
> diff --git a/st.c b/st.c
> index 300e5ec..b203be0 100644
> --- a/st.c
> +++ b/st.c
> _AT_@ -2545,7 +2545,7 @@ xinit(void) {
> XGCValues gcvalues;
> Cursor cursor;
> Window parent;
> - int sw, sh, major, minor;
> + int sw, sh, /*major, minor*/;
>
> if(!(xw.dpy = XOpenDisplay(NULL)))
> die("Can't open display\n");

The warning is a hint for me to remove the Xdbe stuff prior to release.
As you can see below in that function that Xdbe is completely commented
out to check if drawing without it and using our double buffering is
equally fast. It has proven to be, so I will remove the Xdbe dependency.

Anyway, thanks for the contribution.


Sincerely,

Christoph Lohmann
Received on Thu Feb 21 2013 - 06:41:01 CET