Re: [dev] [PATCH] st: Use ascent + descent for font height to avoid clipping underscores.

From: Bobby Powers <bobbypowers_AT_gmail.com>
Date: Sun, 10 Mar 2013 16:28:37 -0400

ha, sounds reasonable :) thanks Christoph!


On Sun, Mar 10, 2013 at 4:17 PM, Christoph Lohmann <20h_AT_r-36.net> wrote:

> Greetings.
>
> On Sun, 10 Mar 2013 21:17:38 +0100 Bobby Powers <bobbypowers_AT_gmail.com>
> wrote:
> > Has an issue with st where the _'s were being overwritten when text on
> > the next line was drawn. This didn't happen in gnome-terminal, which
> > uses pango for its font rendering. Pango's Xft backend uses ascent +
> > descent rather than height. This appears to date back to at least
> > 2004 (pango commit 5bf0c1d0) so I'm not sure their exact reasoning,
> > but it fixes the Monospace font height issue I am seeing.
>
> I applied the patch without the big useless comment. If there would be a
> comment about all wrong behaviour of xft and how bad the fontconfig API
> is, st would double its raw source size.
>
>
> Sincerely,
>
> Christoph Lohmann
>
>
>
Received on Sun Mar 10 2013 - 21:28:37 CET