Re: [dev] [st] Segmentation fault when clicking the top of window

From: Markus Teich <markus.teich_AT_stusta.mhn.de>
Date: Wed, 27 Mar 2013 22:56:12 +0100

Nope,

Juhani's report seems to be from the 0.3 release.
The bug has already been fixed in commit abe85c0e on Nov 3 2012 (one day
after the 0.3 release).
Maybe it is time for 0.4? ;)

--Markus


Am 27.03.2013 21:48, schrieb Christoph Lohmann:
> Greetings.
>
> On Wed, 27 Mar 2013 21:48:14 +0100 Markus Teich <markus.teich_AT_stusta.mhn.de> wrote:
>> Am 27.03.2013 08:41, schrieb Christoph Lohmann:
>>> I thought you would fix the segfault, but instead all I got was a lousy
>>> XML file. :/
>>
>> problem:
>> in config.h borderpx is declared as an unsigned int.
>> in the bpress(XEvent* e) function Y2ROW(e->xbutton.y) is called and gets
>> expanded to:
>> (((e->xbutton.y) - borderpx)/xw.ch)
>> XWindow.ch and XButtonEvent.y are both signed integers but the result is
>> unsigned, so
>> (((0) - 2)/14) for example gets evaluated to something really high and
>> out of range to the term.dirty[] array which causes the bad mem access
>> in line 801.
>>
>> one possible solution:
>> make borderpx signed and hope the users are not stupid enough to set it
>> to a negative value.
>
> Bug reports always have to be reported against latest git revision.
> There this is already true. Can you try, if the bug can be still repro‐
> duced?
>
>
> Sincerely,
>
> Christoph Lohmann
>
>
Received on Wed Mar 27 2013 - 22:56:12 CET