Re: [dev] [PATCH v2] dmenu_run: Don't leave a shell running

From: Ross Lagerwall <rosslagerwall_AT_gmail.com>
Date: Tue, 16 Apr 2013 16:17:08 +0100

On Tue, Apr 16, 2013 at 10:31:24PM +0800, Chris Down wrote:
> On 2013-04-16 14:47, Ross Lagerwall wrote:
> > The previous logic leaves a shell running for the duration that the
> > launched application runs.
> > This changes it so that the only application that is left running is
> > the launched application.
> > ---
> > dmenu_run | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/dmenu_run b/dmenu_run
> > index 834ede5..d05e131 100755
> > --- a/dmenu_run
> > +++ b/dmenu_run
> > _AT_@ -1,2 +1,2 @@
> > #!/bin/sh
> > -dmenu_path | dmenu "$_AT_" | ${SHELL:-"/bin/sh"} &
> > +eval "exec "$(dmenu_path | dmenu "$_AT_")
> > --
> > 1.8.2.1
>
> Your usage of eval is not needed and can result in unintended consequences. Drop
> the quotes around the command substitution if that's what you really want.
>
> Chris

I guess what I meant was what was written in:
http://lists.suckless.org/dev/1304/15327.html

exec $(dmenu_path | dmenu "$_AT_")

Regards
-- 
Ross Lagerwall
Received on Tue Apr 16 2013 - 17:17:08 CEST

This archive was generated by hypermail 2.3.0 : Tue Apr 16 2013 - 17:24:05 CEST