Re: [dev] [st][patch] SWAP macro

From: Christoph Lohmann <20h_AT_r-36.net>
Date: Sun, 05 May 2013 16:54:31 +0200

Greetings.

On Sun, 05 May 2013 16:54:31 +0200 Strake <strake888_AT_gmail.com> wrote:
> From d3455f61a5caaf5d94e2b6c1056fb03713772029 Mon Sep 17 00:00:00 2001
> From: Strake <strake888_AT_gmail.com>
> Date: Tue, 30 Apr 2013 23:53:04 -0500
> Subject: [PATCH] swap

Rejected. You are doing two things wrong: You are using ugly variable
names in an ugly macro and then change code in a different code style.

This swap macro will never be accepted, because it hides a whole vari‐
able which might be really hard to debug.


Sincerely,

Christoph Lohmann
Received on Sun May 05 2013 - 16:54:31 CEST