Re: [dev] [st] [patch] ARGB background for st-0.4.1

From: Chris Down <chris_AT_chrisdown.name>
Date: Wed, 12 Jun 2013 17:06:20 +0800

You probably also need a compositor.
On 12 Jun 2013 09:36, <jiceher_AT_free.fr> wrote:

> Hi,
>
> I would like to test your patch.
> I have successfully applied it to HEAD of st git repository.
> I compile it but it seems that my st it stills not transparent at all (I
> have modified alpha in config.h with different values, same results).
>
> Did you have an example of configuration or I have missed something?
>
> Regards,
>
> JiCeher
>
> ----- Mail original -----
> De: "Eon Seob Jeon" <esjeon_AT_live.com>
> À: dev_AT_suckless.org
> Envoyé: Mercredi 12 Juin 2013 02:34:49
> Objet: [dev] [st] [patch] ARGB background for st-0.4.1
>
> Hi.
>
> I've made a short patch that enables semi-transparent background for
> st-0.4.1. The same mechanism should work with recent commits.
>
> Some important notes:
> 1) This changes background opacity only.
> 2) The color designated by "defaultbg" are modified during the
> initialization, so you should add another color to be used as background.
> (check st.c:2360 to see what actually happens)
> 3) There's a bug in this patch: if st is embeded into an ARGB-enabled
> window, it crashes. (What an irony.)
> 4) The maximum value of 'alpha' is 0xff (= OPAQUE)
>
> Regards
>
> Eon
>
>
>
> diff --git a/config.def.h b/config.def.h
> index d1c20bd..cc9f34d 100644
> --- a/config.def.h
> +++ b/config.def.h
> _AT__AT_ -25,6 +25,8 @@ static char termname[] = "st-256color";
> Â
> Â static unsigned int tabspaces = 8;
> Â
> +/* background opacity */
> +static const int alpha = 0xdd;
> Â
> Â /* Terminal colors (16 first used in escape sequence) */
> Â static const char *colorname[] = {
> _AT__AT_ -52,6 +54,7 @@ static const char *colorname[] = {
> Â
> Â Â Â Â /* more colors can be added after 255 to use with DefaultXX */
> Â Â Â Â "#cccccc",
> +Â Â Â "black",
> Â };
> Â
> Â
> _AT__AT_ -60,7 +63,7 @@ static const char *colorname[] = {
> Â * foreground, background, cursor
> Â */
> Â static unsigned int defaultfg = 7;
> -static unsigned int defaultbg = 0;
> +static unsigned int defaultbg = 257;
> Â static unsigned int defaultcs = 256;
> Â
> Â /*
> diff --git a/config.mk b/config.mk
> index 9431de2..0b92bf2 100644
> --- a/config.mk
> +++ b/config.mk
> _AT__AT_ -14,7 +14,7 @@ X11LIB = /usr/X11R6/lib
> Â INCS = -I. -I/usr/include -I${X11INC} \
> Â Â Â Â Â Â Â `pkg-config --cflags fontconfig` \
> Â Â Â Â Â Â Â `pkg-config --cflags freetype2`
> -LIBS = -L/usr/lib -lc -L${X11LIB} -lX11 -lutil -lXext -lXft \
> +LIBS = -L/usr/lib -lc -L${X11LIB} -lX11 -lutil -lXext -lXft -lXrender \
> Â Â Â Â Â Â Â `pkg-config --libs fontconfig`Â \
> Â Â Â Â Â Â Â `pkg-config --libs freetype2`
> Â
> diff --git a/st.c b/st.c
> index 686ed5d..de4d0f9 100644
> --- a/st.c
> +++ b/st.c
> _AT__AT_ -60,6 +60,7 @@ char *argv0;
> Â #define XK_ANY_MODÂ Â Â UINT_MAX
> Â #define XK_NO_MODÂ Â Â Â 0
> Â #define XK_SWITCH_MOD (1<<13)
> +#define OPAQUE 0Xff
> Â
> Â #define REDRAW_TIMEOUT (80*1000) /* 80 ms */
> Â
> _AT__AT_ -74,6 +75,7 @@ char *argv0;
> Â #define ATTRCMP(a, b) ((a).mode != (b).mode || (a).fg != (b).fg ||
> (a).bg != (b).bg)
> Â #define IS_SET(flag) ((term.mode & (flag)) != 0)
> Â #define TIMEDIFF(t1, t2) ((t1.tv_sec-t2.tv_sec)*1000 +
> (t1.tv_usec-t2.tv_usec)/1000)
> +#define USE_ARGB (alpha != OPAQUE && opt_embed == NULL)
> Â
> Â #define VT102ID "\033[?6c"
> Â
> _AT__AT_ -215,6 +217,7 @@ typedef struct {
> Â Â Â Â int w, h; /* window width and height */
> Â Â Â Â int ch; /* char height */
>     int cw; /* char width */
> +Â Â Â int depth; /* bit depth */
> Â Â Â Â char state; /* focus, redraw, visible */
> Â } XWindow;
> Â
> _AT__AT_ -2335,8 +2338,7 @@ xresize(int col, int row) {
> Â Â Â Â xw.th = MAX(1, row * xw.ch);
> Â
> Â Â Â Â XFreePixmap(xw.dpy, xw.buf);
> -Â Â Â xw.buf = XCreatePixmap(xw.dpy, xw.win, xw.w, xw.h,
> -Â Â Â Â Â Â Â Â Â DefaultDepth(xw.dpy, xw.scr));
> +Â Â Â xw.buf = XCreatePixmap(xw.dpy, xw.win, xw.w, xw.h, xw.depth);
> Â Â Â Â XftDrawChange(xw.draw, xw.buf);
> Â Â Â Â xclear(0, 0, xw.w, xw.h);
> Â }
> _AT__AT_ -2360,6 +2362,13 @@ xloadcols(void) {
> Â Â Â Â Â Â Â }
> Â Â Â Â }
> Â
> +Â Â Â /* set alpha value of bg color */
> +Â Â Â if (USE_ARGB) {
> +Â Â Â Â Â Â dc.col[defaultbg].color.alpha = (0xffff * alpha) / OPAQUE;
> //0xcccc;
> +Â Â Â Â Â Â dc.col[defaultbg].pixel &= 0x00111111;
> +Â Â Â Â Â Â dc.col[defaultbg].pixel |= alpha << 24; // 0xcc000000;
> +Â Â Â }
> +
> Â Â Â Â /* load colors [16-255] ; same colors as xterm */
> Â Â Â Â for(i = 16, r = 0; r < 6; r++) {
> Â Â Â Â Â Â Â for(g = 0; g < 6; g++) {
> _AT__AT_ -2603,7 +2612,38 @@ xinit(void) {
> Â Â Â Â if(!(xw.dpy = XOpenDisplay(NULL)))
> Â Â Â Â Â Â Â die("Can't open display\n");
> Â Â Â Â xw.scr = XDefaultScreen(xw.dpy);
> -Â Â Â xw.vis = XDefaultVisual(xw.dpy, xw.scr);
> +Â Â Â xw.depth = (USE_ARGB)? 32: XDefaultDepth(xw.dpy, xw.scr);
> +Â Â Â if (! USE_ARGB)
> +Â Â Â Â Â Â xw.vis = XDefaultVisual(xw.dpy, xw.scr);
> +Â Â Â else {
> +Â Â Â Â Â Â XVisualInfo *vis;
> +Â Â Â Â Â Â XRenderPictFormat *fmt;
> +Â Â Â Â Â Â int nvi;
> +Â Â Â Â Â Â int i;
> +
> +Â Â Â Â Â Â XVisualInfo tpl = {
> +Â Â Â Â Â Â Â Â Â .screen = xw.scr,
> +Â Â Â Â Â Â Â Â Â .depth = 32,
> +Â Â Â Â Â Â Â Â Â .class = TrueColor
> +Â Â Â Â Â Â };
> +
> +Â Â Â Â Â Â vis = XGetVisualInfo(xw.dpy, VisualScreenMask |
> VisualDepthMask | VisualClassMask, &tpl, &nvi);
> +Â Â Â Â Â Â xw.vis = NULL;
> +Â Â Â Â Â Â for(i = 0; i < nvi; i ++) {
> +Â Â Â Â Â Â Â Â Â fmt = XRenderFindVisualFormat(xw.dpy, vis[i].visual);
> +Â Â Â Â Â Â Â Â Â if (fmt->type == PictTypeDirect &&
> fmt->direct.alphaMask) {
> +Â Â Â Â Â Â Â Â Â Â Â Â xw.vis = vis[i].visual;
> +Â Â Â Â Â Â Â Â Â Â Â Â break;
> +Â Â Â Â Â Â Â Â Â }
> +Â Â Â Â Â Â }
> +Â Â Â Â Â Â
> +Â Â Â Â Â Â XFree(vis);
> +
> +Â Â Â Â Â Â if (! xw.vis) {
> +Â Â Â Â Â Â Â Â Â fprintf(stderr, "Couldn't find ARGB visual.\n");
> +Â Â Â Â Â Â Â Â Â exit(1);
> +Â Â Â Â Â Â }
> +Â Â Â }
> Â
> Â Â Â Â /* font */
> Â Â Â Â if(!FcInit())
> _AT__AT_ -2613,7 +2653,10 @@ xinit(void) {
> Â Â Â Â xloadfonts(usedfont, 0);
> Â
> Â Â Â Â /* colors */
> -Â Â Â xw.cmap = XDefaultColormap(xw.dpy, xw.scr);
> +Â Â Â if (! USE_ARGB)
> +Â Â Â Â Â Â xw.cmap = XDefaultColormap(xw.dpy, xw.scr);
> +Â Â Â else
> +Â Â Â Â Â Â xw.cmap = XCreateColormap(xw.dpy, XRootWindow(xw.dpy,
> xw.scr), xw.vis, None);
> Â Â Â Â xloadcols();
> Â
> Â Â Â Â /* adjust fixed window geometry */
> _AT__AT_ -2647,7 +2690,7 @@ xinit(void) {
> Â Â Â Â parent = opt_embed ? strtol(opt_embed, NULL, 0) : \
> Â Â Â Â Â Â Â Â Â Â XRootWindow(xw.dpy, xw.scr);
> Â Â Â Â xw.win = XCreateWindow(xw.dpy, parent, xw.fx, xw.fy,
> -Â Â Â Â Â Â Â Â Â xw.w, xw.h, 0, XDefaultDepth(xw.dpy, xw.scr),
> InputOutput,
> +Â Â Â Â Â Â Â Â Â xw.w, xw.h, 0, xw.depth, InputOutput,
> Â Â Â Â Â Â Â Â Â Â xw.vis,
> Â Â Â Â Â Â Â Â Â Â CWBackPixel | CWBorderPixel | CWBitGravity |
> CWEventMask
> Â Â Â Â Â Â Â Â Â Â | CWColormap,
> _AT__AT_ -2655,10 +2698,11 @@ xinit(void) {
> Â
> Â Â Â Â memset(&gcvalues, 0, sizeof(gcvalues));
> Â Â Â Â gcvalues.graphics_exposures = False;
> -Â Â Â dc.gc = XCreateGC(xw.dpy, parent, GCGraphicsExposures,
> +Â Â Â xw.buf = XCreatePixmap(xw.dpy, xw.win, xw.w, xw.h, xw.depth);
> +Â Â Â dc.gc = XCreateGC(xw.dpy,
> +Â Â Â Â Â Â Â Â Â (USE_ARGB)? xw.buf: parent,
> +Â Â Â Â Â Â Â Â Â GCGraphicsExposures,
> Â Â Â Â Â Â Â Â Â Â &gcvalues);
> -Â Â Â xw.buf = XCreatePixmap(xw.dpy, xw.win, xw.w, xw.h,
> -Â Â Â Â Â Â Â Â Â DefaultDepth(xw.dpy, xw.scr));
> Â Â Â Â XSetForeground(xw.dpy, dc.gc, dc.col[defaultbg].pixel);
> Â Â Â Â XFillRectangle(xw.dpy, xw.buf, dc.gc, 0, 0, xw.w, xw.h);
>
Received on Wed Jun 12 2013 - 11:06:20 CEST