Re: [dev] sbase: logname

From: Alexander Huemer <alexander.huemer_AT_xx.vu>
Date: Tue, 18 Jun 2013 17:54:56 +0200

On Tue, Jun 18, 2013 at 11:31:13AM -0400, Calvin Morrison wrote:
> is there an interest in having the logname tool?
>
> I have a basic implementation of it here:
>
> https://github.com/mutantturkey/corefutiles/blob/master/logname.c

Some personal comments:
* Weird indentation. What coding style is this?
* A default return value of 1 is uncommon
* The end of a function does not need a semicolon

My try is attached.

Kind regards,
-Alexander Huemer

Received on Tue Jun 18 2013 - 17:54:56 CEST

This archive was generated by hypermail 2.3.0 : Tue Jun 18 2013 - 18:00:09 CEST