Re: [dev] [sbase] [patch v3] Add md5sum

From: sin <sin_AT_2f30.org>
Date: Wed, 3 Jul 2013 14:43:24 +0300

On Wed, Jul 03, 2013 at 01:16:35PM +0200, Szabolcs Nagy wrote:
> * Robert Ransom <rransom.8774_AT_gmail.com> [2013-07-03 10:26:03 +0000]:
> > On 7/3/13, Galos, David <galosd83_AT_students.rowan.edu> wrote:
> > >> Added LICENSE.lpl as well and updated the license and copyright details
> > >> for
> > >> the md5 code.
> > >
> > > I am considering applying this patch. The license is why I have to take
> > > time to think. I'm worried about setting a precedent which allows external
> > > differently-licensed software to be swept into sbase. It is clean code,
> > > which is a large part of why I am considering it.
> >
> > Why not use the public-domain MD5 implementation from libtomcrypt?
> >
>
> here is a cleaned up version
>
> http://git.musl-libc.org/cgit/musl/tree/src/crypt/crypt_md5.c
>
> the libtomcrypt version has gratuitous optimizations
> ifdef configurations and useless failure modes

That's cool. I will spend some time today or tomorrow to re-write the
code and send in patch v4.

If that's fine then I can also proceed with sha1sum(1).

Thanks,
stateless
Received on Wed Jul 03 2013 - 13:43:24 CEST

This archive was generated by hypermail 2.3.0 : Wed Jul 03 2013 - 13:48:05 CEST