Re: [dev] [sbase] [patch] Adding mknod

From: Galos, David <galosd83_AT_students.rowan.edu>
Date: Wed, 3 Jul 2013 11:56:43 -0400

> The types array stood out to me as a bit of a code smell.
> After pondering over it for a couple of minutes, I realized
> that you could just do this:
>
> type = argv[1][0] == 'b' ? S_IFBLK : S_IFCHR;
After some thought, I am inclined to agree. This has been
changed.

> Oh, and you should add tar using sltar as a base.
I actually worked on sltar, adding create support. At the
same time, I wrote a cleaner struct-based version, which
I am thinking about adding.
Received on Wed Jul 03 2013 - 17:56:43 CEST