Re: [dev] [PATCH] Add compatibility for OpenBSD in tar

From: sin <sin_AT_2f30.org>
Date: Fri, 19 Jul 2013 19:15:27 +0300

On Fri, Jul 19, 2013 at 04:29:23PM +0200, Roberto E. Vargas Caballero wrote:
> On Fri, Jul 19, 2013 at 09:19:41AM -0400, Galos, David wrote:
> > > OpenBSD defines strlcpy function, and the declaration is a bit different
> > > of the static declartion found in tar.c. The duplication of symbol name
> > > with different type (one extern and other static, one returning int and
> > > the other returning size_t) caused tar couldn't compile in OpenBSD.
> >
> > Since nothing else in sbase makes use of strlcpy I don't think that it's
> > worth librarizing like this. I did it for consistency in `archive`, as I
> > populated the Header. It might be better for now to just call it strlmov,
> > or define a macro STRLCPY.
>
> If we are going to use only in this file then maybe is better use the snprintf
> directly.

+1 - that makes more sense.

Thanks,
sin
Received on Fri Jul 19 2013 - 18:15:27 CEST