Re: [dev] [sic] [patch] const-correctness and formalities

From: sin <sin_AT_2f30.org>
Date: Thu, 22 Aug 2013 01:48:04 +0300

> -static char *
> -eat(char *s, int (*p)(int), int r) {
> +static char*
> +eat(char *s, int (*p)(int), const int r) {
> while(*s != '\0' && p(*s) == r)
> s++;
> return s;
> }

Please do not use char* instead use char *.

> int
> -main(int argc, char *argv[]) {
> +main(const int argc, const char *argv[]) {

Do no use const for main. Doesn't make sense.

Thanks,
sin
Received on Thu Aug 22 2013 - 00:48:04 CEST