Re: [dev] Re: [st] [PATCH] Avoid buffer overflows in the case of key-mapped strings.

From: Roberto E. Vargas Caballero <>
Date: Wed, 9 Oct 2013 20:45:18 +0200

> The other way it is NULL is if the user leaves the string out
> completely, in which case it will default-initialize to NULL. Maybe

It is true, it is other way of getting it, but it is also other error
of the user

> But thinking a bit more, if the button and mask match, then st should
> at least stop searching in mshortcuts[]:

I agree in this point.

> You're right though: given that this is a bad configuration, this
> check isn't that important.

I think we shouldn't check this kind of things, because otherwise
we must check all the parameters from config.h, and it is not done now.
I usually check all the parameters which come from the user, and trust
parameters from the own code, because they are my responsability (or in
this case, is responsability of the user who modified config.h).

Roberto E. Vargas Caballero
'Write programs that do one thing and do it well. Write programs to work
together. Write programs to handle text streams, because that is a
universal interface'
(Doug McIlroy)
In Other Words - Don't design like polkit or systemd
Received on Wed Oct 09 2013 - 20:45:18 CEST

This archive was generated by hypermail 2.3.0 : Wed Oct 09 2013 - 20:48:10 CEST