Re: [dev] [st] [patch] Cleanup config.def.h, eliminate mappedkeys, simplify matching.

From: Roberto E. Vargas Caballero <>
Date: Thu, 24 Oct 2013 21:28:53 +0200

Sorry for the delay, but I am very busy lately :S.

> Note that match() is used in four places, so I can't merge it into kmap().

You are right and I suck. When I wrote this function it was
a part of kmap which became too much complex, so I put the code
in a new function, and I didn't know other guys had used it.

> I've done this, but I'm not sure it reads as well. The existing
> version first checks the *kp fields because if they are zero, the is
> no need to peek at term.mode.

Uhmmm, it is true. We have to be careful with these code, so let me
see with more time if there is some problem or not with this new

And thank you for your efforts :)

Roberto E. Vargas Caballero
'Write programs that do one thing and do it well. Write programs to work
together. Write programs to handle text streams, because that is a
universal interface'
(Doug McIlroy)
In Other Words - Don't design like polkit or systemd
Received on Thu Oct 24 2013 - 21:28:53 CEST

This archive was generated by hypermail 2.3.0 : Thu Oct 24 2013 - 21:36:06 CEST