Re: [dev] [surf] [PATCH] edit not found urls

From: Edgaras <devoas_AT_gmail.com>
Date: Mon, 13 Jan 2014 18:16:45 +0200

On Sun, Jan 12, 2014 at 09:52:53PM +0000, Nick wrote:
> Quoth Edgaras:
> > Since I do not use any history or bookmarks, for a very long time it bugged me
> > that if you misspell address and page is not found, when you try to edit
> > address you do not get what you have entered, but get "about:blank" instead.
>
> Good, thanks for looking at that, it bugs me too.
>
> Glancing at that line I wonder whether its purpose is to ensure
> redirects update the uri appropriately. Can you check if this patch
> affects that? If so maybe it's best just to only update the AtomUri
> if it isn't about:blank?

This line only affects when you order surf to load url "manually". It should
not affect clicked links or redirects. This is handleded using callback
"loadstatuschange". At least to my understanding. Also history navigation seems
to be "handled" there too. In reality I did not dwell to deep into this. I
tried to solve mentioned history problem, but somehow 404'ed url was hard to
extract from history without introducing other problems. There is a posibility
of mirroring webkits history list, but do not think that is needed.

To be fair I'm not exactly sure what is your concern. I guess you'r worried
that when entering url, getting redirected and trying to edit url you would
get original url you entered and not the real/current one. That is not the
case, url setting for that is in previously mentioned callback.
Received on Mon Jan 13 2014 - 17:16:45 CET