Re: [dev] [surf] [PATCH] Clean up SSL validation

From: Christoph Lohmann <>
Date: Thu, 30 Jan 2014 19:40:21 +0100


On Thu, 30 Jan 2014 19:40:21 +0100 Steve Dee <> wrote:
> soup_message_get_flags returns a bunch of flags besides
> SOUP_MESSAGE_CERTIFICATE_TRUSTED, so the XOR check was incorrect.
> While I was tracking this bug, I switched from libsoup's deprecated [0]
> ssl-ca-file to its non-deprecated tls-database property. I don't know if I
> did that properly, having never touched glib nor being able to find whether
> g_object_set transfers pointers. So here's two patches, one almost
> certainly good and somewhat important, and the other of unknown validity
> and unimportant.

Both of your patches have been applied. Thank you for sending them!


Christoph Lohmann
Received on Thu Jan 30 2014 - 19:40:21 CET

This archive was generated by hypermail 2.3.0 : Thu Jan 30 2014 - 19:48:11 CET