Re: [dev] [PATCH] [st 1/3] Use tsetdirt in tscrollup and tscrolldown.

From: Roberto E. Vargas Caballero <k0ga_AT_shike2.com>
Date: Tue, 22 Apr 2014 21:34:58 +0200

Hi,

        I like these patches, and I want to apply them, but there is a
small thing that I think should be modified. After the patches tscolldown
has:

        tsetdirt(orig, term.bot-n);
        tclearregion(0, term.bot-n+1, term.col-1, term.bot);

but tscrollup has:

        tclearregion(0, orig, term.col-1, orig+n-1);
        tsetdirt(orig+n, term.bot);

        Is there any reason to do it in different order?. I think is more
understable if the order is the same in both cases.

Regards,

-- 
Roberto E. Vargas Caballero

Received on Tue Apr 22 2014 - 21:34:58 CEST