Re: [dev] [st patch queue 06/12] Avoid integer overflow in dump().

From: Roberto E. Vargas Caballero <k0ga_AT_shike2.com>
Date: Fri, 25 Apr 2014 18:16:59 +0200

> _AT_@ -1234,8 +1234,10 @@ dump(char c) {
> static int col;
>
> fprintf(stderr, " %02x '%c' ", c, isprint(c)?c:'.');
> - if(++col % 10 == 0)
> + if(++col == 10) {
> fprintf(stderr, "\n");
> + col = 0;
> + }
> }

dump is not used in any place. It is dead code, so I think the solution is
to remove the function.

Regards,

-- 
Roberto E. Vargas Caballero

Received on Fri Apr 25 2014 - 18:16:59 CEST