Re: [dev] [st] [PATCH] Simplify selected().

From: <noname_AT_inventati.org>
Date: Mon, 28 Apr 2014 21:35:35 +0400

On Mon, Apr 28, 2014 at 06:58:29PM +0200, Roberto E. Vargas Caballero wrote:
> Uhmmm, I am not sure about this patch, because it is related to some
> parts of st that are not handled by me, and I am not sure if these
> modifications are correct. Could someone else take care of this patch?
>
> Regards,
>
> --
> Roberto E. Vargas Caballero
>

If you select rectangle, then y should be between first and last line
and x should between first and last column.

If selection is normal, then y should be between first and last line of
selection.

Also
        (y != sel.nb.y || x >= sel.nb.x)
should be read as
        y == sel.nb.y implies x >= sel.nb.x
and
        (y != sel.ne.y || x <= sel.ne.x)
should be read as
        y == sel.nb.y implies x <= sel.ne.x

It is also easy to visually check that selection works properly.
Received on Mon Apr 28 2014 - 19:35:35 CEST