[dev] Re: [PATCH] [slock] Use MODE and GROUP in install

From: Steve Dee <steve_AT_smartercode.net>
Date: Tue, 10 Jun 2014 23:21:25 -0700

Bump. The unpatched code doesn't work properly on BSD for reasons not
obvious to the person compiling it.


On Mon, Apr 28, 2014 at 10:46 AM, Steve Dee <steve_AT_smartercode.net> wrote:
>
> ---
> Makefile | 4 ++--
> config.mk | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 2bea555..d53171c 100644
> --- a/Makefile
> +++ b/Makefile
> _AT_@ -40,8 +40,8 @@ install: all
> _AT_echo installing executable file to ${DESTDIR}${PREFIX}/bin
> _AT_mkdir -p ${DESTDIR}${PREFIX}/bin
> _AT_cp -f slock ${DESTDIR}${PREFIX}/bin
> - _AT_chmod 755 ${DESTDIR}${PREFIX}/bin/slock
> - _AT_chmod u+s ${DESTDIR}${PREFIX}/bin/slock
> + _AT_chgrp ${GROUP} ${DESTDIR}${PREFIX}/bin/slock
> + _AT_chmod ${MODE} ${DESTDIR}${PREFIX}/bin/slock
>
> uninstall:
> _AT_echo removing executable file from ${DESTDIR}${PREFIX}/bin
> diff --git a/config.mk b/config.mk
> index 8cc3f68..aee4b79 100644
> --- a/config.mk
> +++ b/config.mk
> _AT_@ -26,5 +26,5 @@ CC = cc
>
> # Install mode. On BSD systems MODE=2755 and GROUP=auth
> # On others MODE=4755 and GROUP=root
> -#MODE=2755
> -#GROUP=auth
> +MODE=4755
> +GROUP=root
> --
> 1.8.5.2 (Apple Git-48)
>
Received on Wed Jun 11 2014 - 08:21:25 CEST