Re: [dev] [PATCH] Move default rows, cols to config.def.h

From: Alexander S. <alex0player_AT_gmail.com>
Date: Wed, 25 Jun 2014 03:43:45 +0400

2014-06-25 3:42 GMT+04:00 Alexander S. <alex0player_AT_gmail.com>:
> 2014-06-25 1:51 GMT+04:00 Anders Eurenius <aes_AT_spotify.com>:
>> Move default rows, cols to config.def.h
>>
>> Add default_cols, default_rows as static ints in the config.def.h
>> header, instead of using constants directly in the code.
>>
>> cheers
>> aes
> Greetings,
> is this really necessary? Default constants don't really mean
> anything, they persist literally until the window is mapped and the
> text buffer is resized at
(apologies for accidentally sending)
L3726, so if anything, I'd vote for their removal, not their
canonicalization through config.[def.]h.

-- 
Best regards, Alexander Sedov.
Received on Wed Jun 25 2014 - 01:43:45 CEST

This archive was generated by hypermail 2.3.0 : Wed Jun 25 2014 - 01:48:11 CEST