[dev] [st] possibly redundant check in techo

From: Steven Degutis <sbdegutis_AT_gmail.com>
Date: Thu, 14 Aug 2014 16:38:24 -0500

Convenience link to the line: http://git.suckless.org/st/tree/st.c#n2315

Here, techo is calling ISCONTROL(c) where c is a 'char'. But
ISCONTROLC1 is always going to return false for a char.

Perhaps it should test against ISCONTROLC0 instead? Or is this line
intended to use ISCONTROL for some reason?

For the record, I came across this while porting st to OS X using
native APIs (NSWindow, NSView, CoreText, etc).

Received on Thu Aug 14 2014 - 23:38:24 CEST

This archive was generated by hypermail 2.3.0 : Thu Aug 14 2014 - 23:48:07 CEST