Re: [dev] [st][PATCH] Add support for utmp in st

From: Marc André Tanner <mat_AT_brain-dump.org>
Date: Fri, 10 Oct 2014 12:33:04 +0200

Hi,

On Tue, Sep 23, 2014 at 07:18:32AM +0200, Roberto E. Vargas Caballero wrote:
> --- a/st.c
> +++ b/st.c
> _AT_@ -1153,16 +1153,22 @@ execsh(void) {

...

> - setenv("SHELL", sh, 1);
> + setenv("SHELL", args[0], 1);

I'm not sure whether this is a good idea? The user asked to execute
args[0] instead of the shell, but this doesn't imply that args[0] is
his shell.

With this change "st -e dvtm" results in a fork bomb because dvtm
uses $SHELL to launch its internal windows and thus executes itself
within itself ...

-- 
 Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0
Received on Fri Oct 10 2014 - 12:33:04 CEST

This archive was generated by hypermail 2.3.0 : Fri Oct 10 2014 - 12:36:08 CEST