Re: [dev] [dmenu] [PATCHES 1-5] Changes and cleanup

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]

From: <k0ga_AT_shike2.com>
Date: Tue, 23 Dec 2014 16:11:16 +0100

>> The style(9)-changes were absolutely necessary and it's better to do this
>> as early as possible instead of waiting and waiting until it's too late
>> and you have a really big number of patches for a given program.
>
> The thing I dislike most about the style changes is the alignment of
> variable and function definitions, and the reason I don't like
> alignment-based definitions is because the moment you need to add a new
> variable or function that has a column that's one character longer than
> the existing definitions, you end up with a diff that modifies a bunch
> of a lines that are not necessarily related to the new feature.
>

I agree with Eric here. I don't see the point of variables alignment.

Regards,
Received on Tue Dec 23 2014 - 16:11:16 CET

This archive was generated by hypermail 2.3.0 : Tue Dec 23 2014 - 16:24:03 CET