Re: [dev] [vis] [PATCH] Set tabwidth and expandtab in config.def.h

From: Matthias Rabault <matthias.rabault_AT_mailoo.org>
Date: Sun, 04 Jan 2015 17:47:58 +0100

I see your point and I agree. I didn't think of that, so I'll have to think of another way to do that, which doesn't change the prototype. Thanks for the insight !

Dimitris Papastamos <sin_AT_2f30.org> a écrit :

>> -Editor *editor_new(int width, int height) {
>> +Editor *editor_new(int width, int height, int tabwidth, bool expandtab) {
>
>I am not affiliated with vis or have any familiarity with it
>but this doesn't make sense. I'd expect tabwidth/expandtab to be global
>variables in this case as they affect global state.
>
>This approach quickly doesn't scale if you want more parameters to
>be configured by the user and skews the semantics of the function.
>
Received on Sun Jan 04 2015 - 17:47:58 CET