Re: [dev] disk cache patch

From: Christoph Lohmann <20h_AT_r-36.net>
Date: Sat, 17 Jan 2015 20:54:27 +0100

Greetings.

On Sat, 17 Jan 2015 20:54:27 +0100 Ben Woolley <tautolog_AT_gmail.com> wrote:
> Hi all,
>
> It turns out that enabling libsoup's disk cache is fairly straightforward.
>
> I left it enabled by default in the patch, but I am not proposing that in
> any way. I am pretty sure this will apply fairly cleanly with other
> patches, except maybe the change of the size of the togglestat struct.
>
> There is probably a concurrency issue with this, where multiple surf
> instances open the same cache. Note that I load on startup, and flush after
> each page load. At least I haven't run into any corruption issues with it,
> so maybe the worst that comes of that issue is fewer cache hits. Compared
> to no cache at all, it is an improvement.
>
> I used the command line options "d" and "D".
>
> Beware that a disk cache may hold cache-based trackers for a longer
> duration than the memory-only cache that is the default. I recommend
> disabling the cache in any private sessions.

Thanks for the patch. I merged it into the current tree and added the
appropriate manpage change.


Sincerely,

Christoph Lohmann
Received on Sat Jan 17 2015 - 20:54:27 CET