Re: [dev] [st] [PATCH] Correct shift amount on MODE_INSERT in tputc()

From: <k0ga_AT_shike2.com>
Date: Fri, 30 Jan 2015 12:19:18 +0100

> On Fri, Jan 30, 2015 at 12:41 AM, FRIGN <dev_AT_frign.de> wrote:
>> On Thu, 29 Jan 2015 15:08:39 -0800
>> Rian Hunter <rian+suckless-dev_AT_thelig.ht> wrote:
>>
>>> When MODE_INSERT is set we'd shift characters on the same
>>> line forward before inserting our character in tputc().
>>> This did not account for wide characters where width != 1.
>>> This patch makes it so we shift the correct amount.
>>

Good catch, I'll test the patches this weekend (I am a bit
busy now). I think we can have this problem in other places,
maybe could be a good idea test all the places where we have
a +1.

>
>> However, next time, please attach the patches
>> instead of inserting them so people with insane
>> mail clients can easily access them without hassle.
>
> I don't think we should encourage this behavior on this list.
> Shouldn't we rather assume that people on this list are using sane
> mail clients that let them easily save their mails to disk so that
> they can use 'git am' to apply them?
>

I agree with Silvan. Patches in the body simplify the discussion,
and we should benefit people that use sane mail clients instead
of people don't do it.


Regards,
Received on Fri Jan 30 2015 - 12:19:18 CET