Re: [dev] [PATCH] [sbase] No blkcnt_t on OpenBSD

From: Hiltjo Posthuma <hiltjo_AT_codemadness.org>
Date: Mon, 16 Mar 2015 21:42:37 +0100

On Mon, Mar 16, 2015 at 8:47 PM, Steven Dee <steve_AT_smartercode.net> wrote:
> ---
> du.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/du.c b/du.c
> index 6ecebc9..962e61c 100644
> --- a/du.c
> +++ b/du.c
> _AT_@ -29,7 +29,7 @@ printpath(size_t n, const char *path)
> }
>
> static size_t
> -nblks(blkcnt_t blocks)
> +nblks(size_t blocks)
> {
> return (512 * blocks + blksize - 1) / blksize;
> }
> --
> 1.9.3
>

This should also be signed: "blkcnt_t and off_t shall be signed
integer types."[0]

On my OpenBSD 5.6 install st_blocks is also defined as int64_t, but on
-current this is fixed like Dimitris said.

Kind regards,
Hiltjo

[0] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_types.h.html
Received on Mon Mar 16 2015 - 21:42:37 CET

This archive was generated by hypermail 2.3.0 : Mon Mar 16 2015 - 21:48:07 CET