Re: [dev] [vis] buffer_alloc issues

From: <noname_AT_inventati.org>
Date: Sun, 29 Mar 2015 14:59:24 +0000

On Sun, Mar 29, 2015 at 03:45:50PM +0200, Silvan Jegen wrote:
> Heyho!
>
> On Wed, Mar 25, 2015 at 07:15:08PM +0000, noname_AT_inventati.org wrote:
> > There are two issues with buffer_alloc function(s).
> >
> > First function is located in buffer.c:
> > http://repo.or.cz/w/vis.git/blob/HEAD:/buffer.c
> >
> > The problem is on line 15:
> > http://repo.or.cz/w/vis.git/blob/HEAD:/buffer.c#l15
> >
> > If realloc fails, buf->data is set to NULL, but original buf->data is
> > not freed, see realloc(3). The result of realloc should be stored in
> > separate variable and buffer_free should be called to free buf->data and
> > set size and len to 0 if realloc fails.
>
> This is true. In a memory-overcommitting system like Linux, however,
> this should not be a problem in practice since realloc should never fail.

Then NULL check is a dead code and should be removed.
Received on Sun Mar 29 2015 - 16:59:24 CEST

This archive was generated by hypermail 2.3.0 : Sun Mar 29 2015 - 17:12:08 CEST