Re: [dev] [vis] [PATCH] Fixed multiline comment regexp.

From: Marc André Tanner <mat_AT_brain-dump.org>
Date: Fri, 3 Apr 2015 19:21:49 +0200

On Thu, Apr 02, 2015 at 02:27:31AM +0300, noname wrote:
> Comments like "/***/" with odd number of asterisks are handled like
> normal comments now. Previously they were handled like unfinished
> comments.

Could you please provide a more complete test case? I can't seem to
reproduce it here.

> Support for comments without opening "/*" at the beginning of the file
> is removed because people do not normally write comments backwards.

At the moment vis only considers the currently visible text for syntax
highlighting. The rule you removed is a hack to catch multiline comments
even when their start marker "/*" has been scrolled off the screen.

And yes the whole syntax hightlighting probably needs a redesign.
At some point I should take a look how vim/sublime/other editors
which supports a lot of languages configure their syntax highlighting
and reuse/convert their rule set.

However given the implementation complexity (~50 LOC without rules)
of the current solution, it works suprisingly well (at least for C
like languages) ...

-- 
 Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0
Received on Fri Apr 03 2015 - 19:21:49 CEST

This archive was generated by hypermail 2.3.0 : Fri Apr 03 2015 - 19:24:08 CEST