Re: [dev] [st] [PATCH 2/2] Simplify window mapping loop.

From: <noname_AT_inventati.org>
Date: Fri, 10 Apr 2015 20:10:10 +0000

On Fri, Apr 10, 2015 at 05:41:16PM +0200, Roberto E. Vargas Caballero wrote:
> > - if(XFilterEvent(&ev, None))
> > - continue;
>
> Why are you removing the call to XFilterEvent here?

XFilterEvent usually filters KeyPress events that are hooked by input
method, but at this point the window is not mapped so it is impossible
to press keys in the terminal.

Calling XFilterEvent would only be useful if input methods filtered
ConfigureNotify or MapNotify events. I don't think we want to ignore our
ConfigureNotify or MapNotify only because some broken input method
steals it.
Received on Fri Apr 10 2015 - 22:10:10 CEST