Re: [dev] [surf] [PATCH] Add NODISKCACHE option to disable the disk cache at compile-time

From: <tautolog_AT_gmail.com>
Date: Tue, 14 Apr 2015 12:41:11 -0700

Cool. My concern is about adding "unstable" code on a "stable" distribution. ‎The disk cache is disabled by default, so it is probably not an issue. If someone enables it, it is their decision.

I am not the maintainer, so it isn't my call, but if the maintainer wants my input as the original submitter of this feature, the two line patch looks like fine to me. The only issue is that this is code that is likely to go stale as the old code disappears from systems, and so maybe it should just be left as a patch on the website for distributions to manage. If it were me, I would put the two lines together with a comment saying that it is a temporary hack that should be removed in the future. I would personally include it myself, but I am not sure where it stands in the suckless philosophy.

If the maintainer wants to reject it, I will package it up as a patch for the website, citing the build error, and see if it gets accepted there. 

Ben
  Original Message  
From: Nick
Sent: Tuesday, April 14, 2015 12:16 PM
To: dev mail list
Reply To: dev mail list
Subject: Re: [dev] [surf] [PATCH] Add NODISKCACHE option to disable the disk cache at compile-time

Quoth tautolog_AT_gmail.com:
> On those platforms that need that define set before the include, does the -D argument actually work?

Yep, the cache seems to work fine.
Received on Tue Apr 14 2015 - 21:41:11 CEST