Re: [dev] [st] [PATCH 2/5] Replace for with while.

From: <noname_AT_inventati.org>
Date: Sun, 19 Apr 2015 22:27:20 +0000

On Sun, Apr 19, 2015 at 10:40:18AM +0200, Roberto E. Vargas Caballero wrote:
> > As per "The C Programming Language 2nd Edition" and the BSD style guide,
> > the "proper" way to loop infinitely in C is "for(;;)".
> > I agree about moving the assignment out of the loop initialization
> > though. It is cleaner this way.
>
> I totally agree. for (;;) is the only one true ;). I will review all
> the other patches and I will push my patch of serial line tomorrow.
>
> Nonamed, I can see almost all your patches are about small changes
> related to style, and although I accept them, I think I will apreciate
> more your help in another topics. There are several known seauences
> that are not implemented and, the very important, is the branch I
> created (wchar) in order to change the internal representation of
> characters in st. You can follow the discussion in previous messages
> of the mailing list (if you are really interested I can give you the
> mail thread were we discussed about this point).

I read that thread and checked the branch. I will try to rebase the
branch on top of master manually and see if storing long instead of
char[UTF_SIZ] will simplify the code.

I do not think changing 'long' to 'wchar_t' is a good idea because
'wchar_t' has undefined size and long is at least 32-bit long.
Received on Mon Apr 20 2015 - 00:27:20 CEST