Re: [dev] [PATCH] Make build shut up about system() without return value check.

From: Roberto E. Vargas Caballero <k0ga_AT_shike2.com>
Date: Tue, 21 Apr 2015 19:07:31 +0200

> st.c:1321:2: warning: ignoring return value of function declared with warn_unused_result attribute [-Wunused-result]
> system(cmd);
> ^~~~~~ ~~~


I usually don't care about this kind of warnings, but in this case I
think we should check the value returned by system, because in
case of error the user has little opportunity to realize what is the
problem (it will only see that the serial connection works bad).


> Debatable whether an error here should case exit(EXIT_FAILURE). Just
> preserving the existing behaviour for now.

Yeah, this is the point. Is it must be an error? I think so.

Regards,
Received on Tue Apr 21 2015 - 19:07:31 CEST