Re: [dev] [PATCH 4/5] selsnap: remove prevdelim variable

From: Roberto E. Vargas Caballero <k0ga_AT_shike2.com>
Date: Mon, 4 May 2015 11:28:10 +0200

> _AT_@ -753,14 +752,13 @@ selsnap(int *x, int *y, int direction) {
>
> gp = &term.line[newy][newx];
> delim = ISDELIM(gp->u);
> - if(!(gp->mode & ATTR_WDUMMY) && (delim != prevdelim
> + if(!(gp->mode & ATTR_WDUMMY) && (delim != ISDELIM(prevgp->u)

I prefer the current code because your code implies this code in all the
iterations:

        (BETWEEN(u, 0, 127) && strchr(worddelimiters, u) != NULL)

and I think is better to hold the result in prevdelim.

Regards,
Received on Mon May 04 2015 - 11:28:10 CEST