Re: [dev] [st] question about 24-bit color support

From: Roberto E. Vargas Caballero <k0ga_AT_shike2.com>
Date: Tue, 2 Jun 2015 09:24:05 +0200

Hi,


> But fg is defined as a ushort. [4]
>
> typedef struct {
> Rune u; /* character code */
> ushort mode; /* attribute flags */
> ushort fg; /* foreground */
> ushort bg; /* background */
> } Glyph;
>
> Since a ushort can only hold 16 bits, I don't see how this can possibly work.

You are right, it is a bug introcuded in 7ab6c92. This patch tried to
reduce the memory consumption, because it uses only values between 0-15,
and sometimes 0-255, but in the case of real color we need 32 bits.
So we have to revert that commit.

Regards,
Received on Tue Jun 02 2015 - 09:24:05 CEST