Re: [dev] [dwmstatus] barM.c security and enhancement patch.

From: Christoph Lohmann <20h_AT_r-36.net>
Date: Sun, 14 Jun 2015 09:45:31 +0200

Greetings.

On Sun, 14 Jun 2015 09:45:31 +0200 Programmer Nerd <theprogrammernerd_AT_gmail.com> wrote:
> I noticed that barM.c obtained from here
> dwm.suckless.org/dwmstatus/barM.c was using fixed buffers without
> concern for the length of said buffer creating the possibility of a
> buffer overflow.
>
> I have also declared global variables and functions static because
> there is only one file. This may lead to slightly better generated
> code.
>
> I have also made the program loop in order to eliminate the bash loop.
> There is no advantage to looping in bash.
>
> Finally I have made slight improvements to some of the comments.

You can push changes to the wiki directly: [0]


Sincerely,

Christoph Lohmann

[0] http://suckless.org/wiki
Received on Sun Jun 14 2015 - 09:45:31 CEST

This archive was generated by hypermail 2.3.0 : Thu Jun 18 2015 - 17:35:33 CEST