Re: [dev] [dvtm] TAGKEYS macro for dvtm

From: Marc André Tanner <mat_AT_brain-dump.org>
Date: Tue, 23 Jun 2015 12:53:46 +0200

Sorry for the delay, I'm catching up ...

On Tue, May 26, 2015 at 02:35:42PM -0400, Ross Mohn wrote:
> diff --git a/config.def.h b/config.def.h
> index b0a68d4..b7d4769 100644
> --- a/config.def.h
> +++ b/config.def.h
> _AT_@ -51,7 +51,7 @@ static Color colors[] = {
> /* curses attributes for not selected tags which with urgent windows */
> #define TAG_URGENT (COLOR(BLUE) | A_NORMAL | A_BLINK)
>
> -const char tags[][8] = { "1", "2", "3", "4", "5" };
> +const char tags[][8] = { "1", "2", "3", "4", "5", "6", "7", "8", "9" };

I left out this part for now. While I'm not generally opposed to it,
I think it should be changed independently. From time to time I work
in a 80x24 setting and wonder whether spending that much space for
tags makes sense ...

> + TAGKEYS( '1', 0)

Also it might be more intuitive to pass in the same tag number here
and subtract one inside the TAGKEYS macro? I.e.

  TAGKEYS('1', 1)

But as it is the same in dwm, I will leave it for now ...

Thanks

-- 
 Marc André Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0
Received on Tue Jun 23 2015 - 12:53:46 CEST

This archive was generated by hypermail 2.3.0 : Tue Jun 23 2015 - 13:00:12 CEST