Re: [dev] Input method under break (again) under st

From: Roberto E. Vargas Caballero <k0ga_AT_shike2.com>
Date: Thu, 2 Jul 2015 08:30:30 +0200

Hi,

On Wed, Jul 01, 2015 at 09:40:41AM -0700, Weng Xuetian wrote:
> Some fcitx user reaches me about input method issue, and I surprisingly found
> that input method is broken again in st because I have fixed it once.

Yes. Maybe it is my fault because I didn't tested this part of st.
>
> The new issue is caused by commit 2937b05aed9cee8d6651cd806d31682a853c773
> which removes a XFilterEvent call.

Are you sure this is the commit?

$ git fetch
$ git log -n1
commit bdd649a10289ade364f3deab3bbf6ee3169d67ca
Author: Quentin Rameau <quinq_AT_quinq.eu.org>
Date: Sun May 31 12:26:11 2015 +0200
    do not truncate font size when zooming
$ git log -n1 2937b05aed9cee8d6651cd806d31682a853c773
fatal: ambiguous argument '2937b05aed9cee8d6651cd806d31682a853c773': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

> XFilterEvent is required to be called after you using XOpenIM, this is not
> unnecessary. It does not only filter the key event, but some clientmessage for
> input method as well.

I can see it. We must add a comment to avoid this kind of problems in the future.

Regards,
Received on Thu Jul 02 2015 - 08:30:30 CEST