Re: [dev][ubase][PATCH] fix several problems in dd

From: Dimitris Papastamos <sin_AT_2f30.org>
Date: Fri, 1 Jan 2016 12:15:18 +0000

On Fri, Jan 01, 2016 at 12:52:31PM +0100, FRIGN wrote:
> On Fri, 01 Jan 2016 11:21:05 +0100
> isabella parakiss <izaberina_AT_gmail.com> wrote:
>
> Hey Isabella,
>
> > i've been told on #2f30 that my opinion is void until i submit meaningful
> > patches. this is a rant^Wbreakdown and fix of a random tool in ubase
>
> I'll look deeper into this later, but I want to note here that back in the
> day, dd was imported into ubase from some foreign repo for some performance
> tweaks. I was sure back then when Dimitris told me, that this is going to
> bite us.

Well yes, importing code that is not thoroughly understood has the
potential to cause problems later on. However, this version of dd was
stripped down quite a bit from the upstream one.

At the end of the day, a bug is a bug irrespective of how it was introduced.

I will have a look at the patch tomorrow.
Received on Fri Jan 01 2016 - 13:15:18 CET