Re: [dev] [PATCH] Change an eprintf to a die to stop child from running its own slideshow

From: Markus Teich <markus.teich_AT_stusta.mhn.de>
Date: Wed, 20 Jan 2016 08:27:15 +0100

David Phillips wrote:
> On Thu, Jan 14, 2016 at 09:47:37AM +0000, Dimitris Papastamos wrote:
> > On Thu, Jan 14, 2016 at 09:02:43PM +1300, David Phillips wrote:
> > > diff --git a/sent.c b/sent.c
> > > index fc5e389..88abe90 100644
> > > --- a/sent.c
> > > +++ b/sent.c
> > > _AT_@ -153,7 +153,7 @@ filter(int fd, const char *cmd)
> > > close(fds[0]);
> > > close(fds[1]);
> > > execlp(cmd, cmd, (char *)0);
> > > - eprintf("execlp %s:", cmd);
> > > + die("execlp %s:", cmd);
> > > }
> > > close(fds[1]);
> > > return fds[0];
> > > --
> > > 2.6.2
> > >
> >
> > I should mention there are many more places in the code where this
> > issue happens.
>
> You are probably right, but this one was the most annoying one to try and
> understand the cause of up until the penny finally dropped.

Heyho,

oops, I already had that merged localy, but forgot to push. Should be upstream
now.

--Markus
Received on Wed Jan 20 2016 - 08:27:15 CET