Re: [dev] [sbase] diff

From: FRIGN <dev_AT_frign.de>
Date: Wed, 27 Jan 2016 23:05:09 +0100

On Wed, 27 Jan 2016 20:18:17 +0100
Mattias Andrée <maandree_AT_member.fsf.org> wrote:

Hey Mattias,

thanks for your patch. I haven't looked at it in-depth, but would like
to advise you instead of using this macro-beast:

> +#define printf(...) do {if (printf(__VA_ARGS__) < 0) perror("printf"), exit(EXIT_FAILURE); } while(0)

to rather call fshut on stdout at the end of the program. This will
ensure that in case a write fails, it is well-reported.
It's already bad enough we see these macro-wonders in glibc.

Cheers

FRIGN

-- 
FRIGN <dev_AT_frign.de>
Received on Wed Jan 27 2016 - 23:05:09 CET

This archive was generated by hypermail 2.3.0 : Wed Jan 27 2016 - 23:12:10 CET