Re: [dev] [dwm] Unnecessary scoping blocks

From: Markus Teich <markus.teich_AT_stusta.mhn.de>
Date: Sun, 3 Jul 2016 18:55:40 +0200

Eric Pruitt wrote:
> _AT_@ -944,40 +944,36 @@ void
> grabbuttons(Client *c, int focused)
> {
> updatenumlockmask();
> - {
> - unsigned int i, j;
> - unsigned int modifiers[] = { 0, LockMask, numlockmask, numlockmask|LockMask };
> …
> + unsigned int i, j;
> + unsigned int modifiers[] = { 0, LockMask, numlockmask, numlockmask|LockMask };

Heyho Eric,

you should shift the declarations above the updatenumlockmask() call acording to
"Do not mix declarations and code" from http://suckless.org/coding_style. The
same for the second removed pair of braces.

--Markus
Received on Sun Jul 03 2016 - 18:55:40 CEST