Re: [dev] suckless dns over http client

From: Calvin Morrison <mutantturkey_AT_gmail.com>
Date: Tue, 3 Apr 2018 16:30:42 -0400

On 3 April 2018 at 16:22, harry666t <harry666t_AT_gmail.com> wrote:
>> There is a small bug on line 34: if the statuscode isn't 200 then the
>> response body is never closed.
>
> Thanks Martin. Fixed.
>
>> Probably not a huge deal since this is a command line client, but in
>> long-running servers this will cause file descriptor leaks.
>
> It is a huge deal. If I can't get a small program right, who would
> ever trust me to write a big one correctly?
>

What was the motivation behind this line?

endpoint := c.Endpoints[rand.Int()%len(c.Endpoints)]
Received on Tue Apr 03 2018 - 22:30:42 CEST