From f953ab80b934bdfb3f61db7e6ddbd21950e77ff9 Mon Sep 17 00:00:00 2001 From: Ben Woolley Date: Tue, 24 Mar 2015 00:18:50 -0700 Subject: [PATCH 05/13] Do not trigger a download for subframes that webkit cannot handle. Fixes arbitrary download prompts. Assume that legit downloads are always explicit navigation events. --- surf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/surf.c b/surf.c index cbc5315..5ac1058 100644 --- a/surf.c +++ b/surf.c @@ -465,7 +465,7 @@ createwindow(WebKitWebView *v, WebKitWebFrame *f, Client *c) { static gboolean decidedownload(WebKitWebView *v, WebKitWebFrame *f, WebKitNetworkRequest *r, gchar *m, WebKitWebPolicyDecision *p, Client *c) { - if(!webkit_web_view_can_show_mime_type(v, m)) { + if(!webkit_web_view_can_show_mime_type(v, m) && !webkit_web_frame_get_parent(f)) { webkit_web_policy_decision_download(p); return TRUE; } -- 2.2.2