Re: [dwm] dwm-rpmohn-0.8.diff

On Thu, Aug 10, 2006 at 11:28:31PM -0400, Ross Mohn wrote:
> * Clicks on the status bar to the right of the tab boxes now change the
> client
> focus. A left-click (Button1) calls focusnext and any other button calls
> focusprev.

I thought about this (I also implemented that in the train this
morning), but I realized that this is pretty useless. How often
do you click on the statusbar to focus the next/prev client? I
do that with moving the pointer to the specific client or using
M-{j,k,Return} resp.

Instead of aiming the behavior you described, I added
view-selection with Button1 (leftwards outside the tag buttons)
and Button3 (rightwards outside the tag buttons) beside
keeping Button4/Button5 scrolling. Depending on the mouse in use
this is a combination of both 'worlds'.

First, diff -u would be more clear and easier to read btw.

> + if(!c->isfloat)
> + for(f = clients; f; f = f->next)
> + if(f->isfloat)
> + higher(f);

That is an expensive operation. I recommend you to have a look
into restack() of wmii or into XRestackWindows(3).

Another thing is, if you'd rename dolayout into arrange you
would save a bunch of lines to be patched.

Regards,

-- 
 Anselm R. Garbe  ><><  www.ebrag.de  ><><  GPG key: 0D73F361