Re: [dwm] dwm-1.1 large numbers of clients diff (includes xinerama)

----- Original Message ----
From: Sander van Dijk <a.h.vandijk_AT_gmail.com>
To: dynamic window manager <dwm_AT_10kloc.org>
Sent: Tuesday, 29 August, 2006 4:29:47 PM
Subject: Re: [dwm] dwm-1.1 large numbers of clients diff (includes xinerama)

On 8/29/06, Anselm R. Garbe <arg_AT_10kloc.org> wrote:
> On Tue, Aug 29, 2006 at 05:17:24PM +0200, Sander van Dijk wrote:
> > Hm, I think 'applytag' is a little confusing, since that's not really
> > what it does; not sure what the right name would be though...
>
> Yea, however processmodifiedtagging is a bit long. Maybe
> commit() ?

| Dunno. I'm not really sure exactly how to describe what this function
| does to begin with. Basically it checks if 'sel' is still in the view,
| and updates (part of) the view depending on that. It should be called
| in places where something potentially causes sel to leave the view.
| Not sure yet how to describe that in just one or two words though...

The intent was to have a function where, after you've made a change to the
sel->tags array, calling this takes care of anything the wm has to do
to reflect this change. For example, it also has to be called when you
add a tag to sel, in order to cause the `dots for selected tags' to get
redrawn; I missed this in one of my earlier diffs.

Since it's supposed to encapsulate possible changes as dwm drawing
stuff changes, I like something less specific such as suggested commit() (or
maybe taggingupdated()). (Obviously, I'm suppressing my personal preference for
long names here :-) )

cheers, dave tweed.
Received on Tue Aug 29 2006 - 17:41:48 UTC