Re: focus problem (was: Re: [dwm] Wide Layout Patch for dwm-1.2)

On Thu, Sep 14, 2006 at 11:10:48AM +0200, Anselm R. Garbe wrote:
> On Wed, Sep 13, 2006 at 08:47:19AM +0200, Jukka Salmi wrote:
> > Hi,
> >
> > just in case this was ambigous: the problem described has nothing to
> > do with the wide layout patch. It exists with unpatched dwm. I just
> > reproduced it with 1.6 from hg tip.
> >
> > Jukka Salmi --> dwm (2006-08-31 19:34:20 +0200):
> > [...]
> > > There seems to be a focus problem; I'll try to explain how to reproduce
> > > it:
> > >
> > > - close all clients
> > > - select the first tag
> > > - start a client which matches a rule with isfloat==True
> > > - place the mouse cursor over the client
> > > - select the second tag
> > > - start another client, e.g. a term
> > > - select all tags by calling viewall()
> > > - select the third tag (which has no clients)
> > >
> > > The focus is now still on the client with the second tag...
>
> I can confirm this, but I dunno yet why this happens. Actually
> when looking into the source, I see much potential to
> simplify the complete focus/reorder/restack handling. I'll keep
> that in mind, and I plan todo that before 1.6.

Nah, there are not much simplifications possible without
repeating mistakes which have been already done. Anyway, I
believe I fixed this issue with a single check in focus() to not
focus clients which are invisible. Jukka, can you recheck
please?

Regards,

-- 
 Anselm R. Garbe  ><><  www.ebrag.de  ><><  GPG key: 0D73F361