Re: [dwm] Fwd: Re: maximization handling

On Fri, Sep 22, 2006 at 03:22:30PM +0200, Anselm R. Garbe wrote:
> On Fri, Sep 22, 2006 at 03:17:51PM +0200, Jukka Salmi wrote:
> > Thanks, seems to be almost perfect. Except that non-floating clients
> > should also be togglemax()ed when switching from floating to tiling
> > mode. See attached patch.
> >
> >
> > Cheers, Jukka
> >
> > --
> > bashian roulette:
> > $ ((RANDOM%6)) || rm -rf ~
>
> > diff -r 0db173d7e59c view.c
> > --- a/view.c Fri Sep 22 14:02:41 2006 +0200
> > +++ b/view.c Fri Sep 22 14:59:45 2006 +0200
> > @@ -102,14 +102,8 @@ dotile(Arg *arg) {
> >
> > w = sw - mw;
> > for(n = 0, c = clients; c; c = c->next)
> > - if(isvisible(c)) {
> > - if(c->isfloat) {
> > - if(c->ismax)
> > - togglemax(c);
> > - }
> > - else
> > - n++;
> > - }
> > + if(isvisible(c) && !c->isfloat)
> > + n++;
>
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Is this really intended?
>
> > if(n > 1)
> > h = (sh - bh) / (n - 1);
> > @@ -118,6 +112,8 @@ dotile(Arg *arg) {
> >
> > for(i = 0, c = clients; c; c = c->next) {
> > if(isvisible(c)) {
> > + if(c->ismax)
> > + togglemax(c);
> > if(c->isfloat) {
> > resize(c, True, TopLeft);
> > continue;
>
> Ok, I'm going to apply this...

Everything fine, I only was confused about the offsets in the
diff...

Regards,

-- 
 Anselm R. Garbe  ><><  www.ebrag.de  ><><  GPG key: 0D73F361