Re: [dwm] broken pipes

From: Jukka Salmi <j+dwm_AT_2006.salmi.ch>
Date: Sun, 26 Nov 2006 11:43:26 +0100

Ciao Manu,

Manuel Badzong --> dwm (2006-11-25 08:17:59 +0100):
> mkfifo dwm_pipe
> dwm < dwm_pipe > dwm_pipe

aka `dwm <>dwm_pipe', BTW...

> If dwm ever writes to stdout (does it?)

No, only some error message are written to stderr.

> After reading main.c
> I recognized that "broken pipe" actually means error or eof reading
> stdin. This definitely should be fixed.

Indeed.

> I mainly changed 5 little things in the main event loop:
[...]
> + I replaced fgets with read (I hate this FILE* crap). If for some
> reason you prefer ANSI C over UNIX IO use feof() to catch EOF.
[...]

Thanks for the cleanup. But now that dwm's reading from stdin isn't
line buffered anymore the read string shouldn't be required to have a
trailing newline. See attached patch.

Cheers, Jukka

-- 
bashian roulette:
$ ((RANDOM%6)) || rm -rf ~

Received on Sun Nov 26 2006 - 11:43:27 UTC

This archive was generated by hypermail 2.2.0 : Sun Jul 13 2008 - 14:32:46 UTC